Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes [npm] Sorbet related issues in file fetcher #11384

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jan 23, 2025

What are you trying to accomplish?

Fixes following Sorbet errors

Return value: Expected type [String, String], got type [String, NilClass]
Caller: /home/dependabot/npm_and_yarn/lib/dependabot/npm_and_yarn/file_fetcher.rb:456
Definition: /home/dependabot/npm_and_yarn/lib/dependabot/npm_and_yarn/file_fetcher.rb:488 (Dependabot::NpmAndYarn::FileFetcher#convert_dependency_path_to_name)

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jan 23, 2025
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/sorbet-fixes-npm branch from ce02a8b to 0dc3e0f Compare January 23, 2025 14:14
@sachin-sandhu sachin-sandhu marked this pull request as ready for review January 23, 2025 14:15
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner January 23, 2025 14:15
@sachin-sandhu sachin-sandhu changed the title adds exception handler on invalid deps in manifest file Fixes [npm] Sorbet related issues in fie fetcher Jan 23, 2025
Copy link
Member

@randhircs randhircs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-sandhu sachin-sandhu force-pushed the ssandhu/sorbet-fixes-npm branch from 0dc3e0f to 9d7825e Compare January 23, 2025 14:28
@sachin-sandhu sachin-sandhu merged commit 4a71fac into main Jan 23, 2025
66 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/sorbet-fixes-npm branch January 23, 2025 14:48
@sachin-sandhu sachin-sandhu changed the title Fixes [npm] Sorbet related issues in fie fetcher Fixes [npm] Sorbet related issues in file fetcher Jan 23, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants