Strip PHP 'v' version prefix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greysteil
approved these changes
Jun 8, 2017
This was referenced Apr 27, 2018
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 17, 2023
Pub has introduced a global `--color` flag, and we now get ``` /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:206:in `block (3 levels) in run_dependency_services': dependency_services failed: Unhandled exception: (Dependabot::DependabotError) Invalid argument(s): Could not find an option named "color". #0 ArgResults.wasParsed (package:args/src/arg_results.dart:95) #1 PubCommand._decideOnColors (package:pub/src/command.dart:305) #2 PubCommand.run (package:pub/src/command.dart:182) #3 CommandRunner.runCommand (package:args/command_runner.dart:209) #4 _DependencyServicesCommandRunner.run (file:///Users/deivid/Code/dependabot/dependabot-core/pub/helpers/bin/dependency_services.dart:60) #5 main (file:///Users/deivid/Code/dependabot/dependabot-core/pub/helpers/bin/dependency_services.dart:77) #6 _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:295) #7 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:192) from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:199:in `chdir' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:199:in `block (2 levels) in run_dependency_services' from /Users/deivid/Code/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:168:in `with_git_configured' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:189:in `block in run_dependency_services' from /Users/deivid/Code/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:49:in `block in in_a_temporary_directory' from /Users/deivid/Code/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:49:in `chdir' from /Users/deivid/Code/dependabot/dependabot-core/common/lib/dependabot/shared_helpers.rb:49:in `in_a_temporary_directory' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:182:in `run_dependency_services' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/helpers.rb:36:in `dependency_services_list' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/file_parser.rb:30:in `list' from /Users/deivid/Code/dependabot/dependabot-core/pub/lib/dependabot/pub/file_parser.rb:17:in `parse' from bin/dry-run.rb:553:in `block in <main>' from bin/dry-run.rb:286:in `cached_read' from bin/dry-run.rb:553:in `<main>' ``` when delegating to Pub. This change seems to address that.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.