-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[#67] - 버튼 공통 컴포넌트 디자인 시스템 적용 #69
Open
minh0518
wants to merge
14
commits into
develop
Choose a base branch
from
feat-button-design-system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🚀 Storybook Deploy : https://67a21b40b49ad2ad0c08c418-dkdzkftwpa.chromatic.com/ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관된 이슈 번호
close #67
🌱 주요 변경 사항
버튼 컴포넌트에 디자인 시스템을 추가합니다.
s, m, l 사이즈
테마 variants
텍스트, 아이콘, 멀티(텍스트+아이콘)
사용법
usage: 'text'
variant: 'purple' | 'sora'
size: 'small' |' medium' | 'large'
children: string
usage: 'icon'
variant: 'purple' | 'sora'
size: 'small' |' medium' | 'large'
icon: 컴포넌트
usage: 'multi'
variant: 'purple' | 'sora'
size: 'small' |' medium' | 'large'
icon: 컴포넌트
iconPosition: 'left' | 'right'
children: string
📸 스크린샷 (선택)
🗣 리뷰어에게 할 말 (선택)
기존 테마와 별도로, 사이즈 관련(padding, font-size 등) 토큰을 상수로 따로 분리 + 테마에 등록해 두었습니다.

키값을 위와 같이 한 이유는
xs, m , l 단위로 분리하게 될 경우 그 범위가 너무 커집니다(ex: xxxs, xxxxl)
만약 1, 2, 3 단위로 오름차순으로 키값을 지정하게 될 경우, 중간에 값이 추가되면 그 아래 모든 값들의 키값이 전부 1칸씩 밀리게 돼서 관련 참조값들의 수정이 너무 번거로워집니다.
그래서 이 둘을 혼합하는식으로 사용했습니다.
s_1
이후에 추가가 되어도 같은 카테고리의 값인s_2
만 수정하면 됩니다.@qq8721443
수정된 버튼 디자인 시스템으로 인해 , 기존에 작성했던 부분을 제거해야 했습니다. 관련 커밋
아마 업로드 버튼은 디자인 시스템에 따르는 버튼이 아닐것 같아서(1회성) 나중에 디자인 확정나면 별도의 버튼 컴포넌트를 만들어서 사용해주시면 됩니다!