Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(toks-main): notice slider 이미지 적용 및 window history 없는 경우 home으로 라우팅 #407

Merged
merged 7 commits into from
Mar 3, 2024

Conversation

chaaerim
Copy link
Member

💡 왜 PR을 올렸나요?

  • notice slider에 이미지를 적용했습니다.
  • back button 클릭시 window history가 없는 경우 home page로 routing될 수 있도록 수정했습니다.

💁 무엇이 어떻게 바뀌나요?

  • 디자인 레퍼런스:

💬 리뷰어분들께

@LineGu LineGu enabled auto-merge (squash) February 24, 2024 16:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 96 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@1d48cbf). Click here to learn what that means.

Files Patch % Lines
.../app/toks-main/components/MainPageSlider/index.tsx 0.00% 37 Missing ⚠️
src/common/components/NoticeSlider/index.tsx 0.00% 15 Missing ⚠️
src/app/toks-main/models/notice.ts 0.00% 12 Missing ⚠️
src/common/components/BackHeader/index.tsx 0.00% 8 Missing ⚠️
src/app/toks-main/remotes/notice.ts 0.00% 7 Missing ⚠️
...-main/components/MainPageSlider/SkeletonSlider.tsx 0.00% 5 Missing ⚠️
src/common/utils/http.ts 0.00% 4 Missing ⚠️
src/app/toks-main/constants/queryKeys.ts 0.00% 3 Missing ⚠️
src/app/toks-main/page.tsx 0.00% 3 Missing ⚠️
src/app/template.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #407   +/-   ##
=====================================
  Coverage       ?   0.07%           
=====================================
  Files          ?     188           
  Lines          ?    6550           
  Branches       ?     188           
=====================================
  Hits           ?       5           
  Misses         ?    6545           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@minsgy minsgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LineGu LineGu merged commit 1414323 into dev Mar 3, 2024
2 checks passed
@LineGu LineGu deleted the feat/notice branch March 3, 2024 13:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants