Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Non xhtml namespaceuri #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TheMarksman
Copy link

This PR implements the suggested fix for #4, by letting a user set an explicit xmlns on a tag.

This also adds the minimal possible Travis-CI integration.

Definitely interested in feedback!

@enjalot
Copy link

enjalot commented Feb 18, 2015

Thanks for the contribution! This being a workaround, we want to think a little harder on the right API. It is a little onerous to ask the user to specify the svg namespace in a partial. A more user-friendly workaround could be specifying that a partial is specifically an svg partial (we don't see much use in having a partial that is both svg and html, might as well keep them separate).

We also want to look into properly fixing this so that users dont need to be concerned with the namespace of their partials.

Could you put the Travis fix in a separate pull request so we can go ahead and merge that in?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants