Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[!!!][FEATURE] Introduce EventEvaluationService #1238

Closed
derhansen opened this issue Jun 8, 2024 · 0 comments
Closed

[!!!][FEATURE] Introduce EventEvaluationService #1238

derhansen opened this issue Jun 8, 2024 · 0 comments
Assignees

Comments

@derhansen
Copy link
Owner

derhansen commented Jun 8, 2024

In order to cleanup the EventController, some methods will be moved to EventEvaluationService

Public methods:

  • evaluateForDetailAction
  • evaluateForIcalDownloadAction
  • evaluateForRegistrationAction
  • evaluateForSaveRegistrationAction

The class will contain the following methods from EventController:

  • evaluateSingleEventSetting
  • evaluateIsShortcutSetting
  • evaluateEventPreviewSetting
  • checkPidOfEventRecord

PSR-14 Event EventPidCheckFailedEvent will be changed (breaking) to be called from the new service and the PSR-14 event does not hold the EventController any more.

@derhansen derhansen added this to the 8.0.0 - TYPO3 v13 milestone Jun 8, 2024
@derhansen derhansen self-assigned this Jun 8, 2024
derhansen added a commit that referenced this issue Sep 30, 2024
To reduce logic in EventController, the following functions
have been moved to an own service:

* evaluateSingleEventSetting
* evaluateIsShortcutSetting
* evaluateEventPreviewSetting
* checkPidOfEventRecord

This additionally allows easier testing of the extracted
logic.

As a result or the refactoring, the PSR-14 event call was
moved to `EventEvaluationService`. This results in a
breaking change, because the `EventController` is now
not available via the PSR-14 event any more.

Closes #1238
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant