Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

undef property specs failing with new rspec #70

Closed
deric opened this issue Mar 30, 2016 · 3 comments
Closed

undef property specs failing with new rspec #70

deric opened this issue Mar 30, 2016 · 3 comments

Comments

@deric
Copy link
Owner

deric commented Mar 30, 2016

mesos::property spec with :undef added in 5e48338 are failing with STRICT_VARIABLES on Puppet 3.

 Undefined variable "value" at /home/travis/build/deric/puppet-mesos/spec/fixtures/modules/mesos/manifests/property.pp:27
     # ./spec/defines/property_spec.rb:52:in `block (3 levels) in <top (required)>'

The syntax should be correct, it was introduced here.
@deric
Copy link
Owner Author

deric commented Mar 30, 2016

@JayH5 any ideas?

deric added a commit that referenced this issue Mar 30, 2016
@deric
workaround for #70
5821d24
@JayH5
Copy link
Contributor

JayH5 commented Mar 30, 2016

@deric: 😢 I don't really know. This rspec + Puppet stuff is often quite fragile. Sorry, I don't really have time to dig into this at the moment... Can maybe take a look next week.

@deric deric mentioned this issue Mar 30, 2016
Merged
@deric
Copy link
Owner Author

deric commented Mar 30, 2016

@JayH5 Sure, no problem. Downgrading rspec-puppet to < 2.4.0 seems to resolve the problem. So the problem was probably introduced somewhere here v2.3.2...v2.4.0.

@deric deric mentioned this issue Mar 30, 2016
Closed
@deric deric closed this as completed in c412fb4 Mar 30, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deric @JayH5