google merchant: mejorar la gestión de URLs no encontradas en el serv…

…icio de indexación
descom-es · Jan 17, 2025 · 3e769f9 · 3e769f9
1 parent c3a8063
commit 3e769f9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/Google/Index/Listeners/ProductUnIndexInGoogleListener.php b/src/Google/Index/Listeners/ProductUnIndexInGoogleListener.php
@@ -14,13 +14,12 @@ public function handle(ProductUnpublished $event)
             return;
         }
 
-        // TODO no lo encontrará quizas sea mejor idea conectar a la DB
-        // $product = ProductRepository::get($event->productId);
+        $url = $event->attributes['url'] ?? null;
 
-        // if (! $product || ! isset($product['url'])) {
-        //     return;
-        // }
+        if (! $url) {
+            return;
+        }
 
-        // EnqueueUrlService::unpublish($product['url']);
+        EnqueueUrlService::unpublish($url);
     }
 }
diff --git a/src/Google/Index/Services/IndexUrlService.php b/src/Google/Index/Services/IndexUrlService.php
@@ -4,6 +4,7 @@
 
 use DescomMarket\Feeds\Google\GoogleServiceBuilder;
 use Google\Service\Indexing\UrlNotification;
+use Illuminate\Support\Facades\Http;
 
 class IndexUrlService
 {
@@ -15,10 +16,19 @@ public function run(string $url): void
             return;
         }
 
+        if ($this->isNotFound($url)) {
+            return;
+        }
+
         $urlNotification = new UrlNotification();
         $urlNotification->setType('URL_UPDATED');
         $urlNotification->setUrl($url);
 
         GoogleServiceBuilder::googleIndex()->urlNotifications->publish($urlNotification);
     }
+
+    private function isNotFound(string $url): bool
+    {
+        return Http::get($url)->notFound();
+    }
 }