Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove redundant yaml and @types/yaml packages #500

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Jul 3, 2023

This package is no longer needed: https://github.com/desktop/dugite-native/actions/runs/4923581323/jobs/8795561706#step:5:7

npm WARN deprecated @types/yaml@1.9.7: This is a stub types definition. yaml provides its own type definitions, so you do not need this installed.

This seems to pass npm run check locally, but as a follow-up I couldn't see any mentions of the yaml package so I've removed that to confirm CI passes as well...

@shiftkey shiftkey marked this pull request as ready for review July 3, 2023 18:46
@tidy-dev tidy-dev enabled auto-merge July 6, 2023 12:15
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thanks for the tidying.

@tidy-dev tidy-dev merged commit cf50d02 into desktop:master Jul 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants