-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add arm64 support for Git for Windows and update to 2.47.1 #515
Conversation
Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the `update-git.ts` script. Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1 Ref: git-for-windows/git#3107 (comment) Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
This updates Git by running the `update-git.ts` script, which automatically added the arm64 version of Git as well. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Git LFS has supported Windows arm64 since 2021. Let's add it to the dependencies, now that Git itself also support it. Ref: git-lfs/git-lfs#4586 Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Now that the update-git-lfs.ts script has been updated to include Windows arm64 binaries, running `npm run update-git-lfs` automatically added the Windows arm64 binary to `dependencies.json`. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
e63c685
to
15c67ff
Compare
Now that we're getting native arm64 binaries for both Git and Git LFS, we can start leveraging them in the `build-win32.sh` script. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Now that Windows arm64 is also supported, we can add it to CI and simplify the pipeline while at it. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
15c67ff
to
23d6d13
Compare
@sergiou87 @niik @tidy-dev this might be of interest to y'all 😊 |
You are the best @dennisameling 🥹🥹🥹🥹🥹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! 🎉 🥹
@sergiou87 anything I can do to get this merged? I've also prepared dugite to start using these updated native deps. Thanks! |
Hey @dennisameling !! Later today I will talk to the team about this, but I think we will need to wait for 1 month or so (because of holidays + other stuff going on), if everything goes well everything should be merged in January, and maybe shipped in February? |
@dennisameling checked with the team and yeah, unfortunately this will have to wait 😭 No worries, I can't stop thinking about getting this merged 😂 So I will let you know as soon as we're unblocked 😃 |
No rush, was just curious if there were any blockers on my end 😊 thanks for all the hard work!! |
@dennisameling you have probably seen some movement 😅 Do you mind updating this PR with the latest git binaries with fixes for these vulnerabilities? 🙏 Thank you 🙇♂️ |
It looks like Git 2.48.1 was released, but GfW is slightly behind, so I just went with 2.47.1.2 for now 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Let's get this merged 🥹
Git for Windows added support for arm64 releases in their 2.47.1 version. Let's add support for it in the
update-git.ts
script.I also ran the
update-git.ts
script after adding this change, which correctly added the arm64 version of Git todependencies.json
. I'll leave it up to you if you also want to include that commit already, or if you want to address the version bump separately.Ref: https://github.com/git-for-windows/git/releases/tag/v2.47.1.windows.1
Ref: git-for-windows/git#3107 (comment)