This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Split compiler plugin and its Gradle plugin into separate modules #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3flex
commented
Oct 12, 2022
| add(SubpluginOption(Options.parallel, taskExtension.parallel.get().toString())) | ||
| add(SubpluginOption(Options.rootPath, project.rootDir.toString())) | ||
| add(SubpluginOption(Options.excludes, taskExtension.excludes.get().encodeToBase64())) | ||
| add(SubpluginOption("debug", taskExtension.debug.get().toString())) |
There was a problem hiding this comment.
Going back to untyped strings isn't ideal, but to keep them means adding another module that both the Gradle plugin and the compiler plugin depend on.
The Kotlin compiler will error out if an unrecognised option is passed, so spelling errors here will be picked up for the most part. In future, functional tests should also exercise all options.
schalkms
approved these changes
Oct 14, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler plugin shouldn't include any Gradle-specific code, and the
KotlinCompilerPluginSupportPlugininterface encourages adding a separate compiler plugin dependency by overridinggetPluginArtifact.