chore: pin requests version < 2.32.0 so docker works #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9395 +/- ##
=======================================
Coverage 46.08% 46.08%
=======================================
Files 1228 1228
Lines 155915 155915
Branches 2440 2439 -1
=======================================
+ Hits 71853 71861 +8
+ Misses 83871 83863 -8
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. |
requirements.txt
Outdated
| @@ -5,6 +5,7 @@ | |||
| -r e2e_tests/tests/requirements.txt | |||
| -r bindings/requirements.txt | |||
|
|
|||
| requests<2.32.0 # https://github.com/docker/docker-py/issues/3256 | |||
There was a problem hiding this comment.
I would move this to the files in harness/tests/requirements since this is a dependency of our CLI/SDK deploy code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Fix failing CI due to requests upgrade https://app.circleci.com/pipelines/github/determined-ai/determined/55790/workflows/8ab63a58-4aa3-4545-8311-41611c86049f/jobs/2583683?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
caused by docker/docker-py#3256
Test Plan
CI passes
Checklist
docs/release-notes/.See Release Note for details.