Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: forked from link #9798

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix: forked from link #9798

merged 2 commits into from
Aug 6, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Aug 5, 2024

Ticket

https://hpe-aiatscale.slack.com/archives/CLCE8D998/p1722886900665269
ET-680

Description

fixed the link of forked column in the flat run table

Test Plan

  • Check if the link in the forked column in the flat run table navigate to the correct page

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
@keita-determined keita-determined marked this pull request as ready for review August 5, 2024 20:51
@keita-determined keita-determined requested a review from a team as a code owner August 5, 2024 20:51
@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 3543f93
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66b2575131bc3a0008d51555
😎 Deploy Preview https://deploy-preview-9798--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.74%. Comparing base (80822eb) to head (3543f93).
Report is 4 commits behind head on main.

Files Patch % Lines
webui/react/src/pages/FlatRuns/columns.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9798      +/-   ##
==========================================
- Coverage   54.05%   49.74%   -4.32%     
==========================================
  Files        1260      937     -323     
  Lines      155591   126259   -29332     
  Branches     3504     3503       -1     
==========================================
- Hits        84108    62806   -21302     
+ Misses      71337    63307    -8030     
  Partials      146      146              
Flag Coverage Δ
harness ?
web 53.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/FlatRuns/columns.ts 17.95% <0.00%> (-0.04%) ⬇️

... and 323 files with indirect coverage changes

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined merged commit 8173cab into main Aug 6, 2024
82 of 95 checks passed
@keita-determined keita-determined deleted the fix/forked-from-link branch August 6, 2024 17:22
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
(cherry picked from commit 8173cab)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants