Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: exclude Array type columns #9808

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Aug 8, 2024

Ticket

ET-654

Description

excluding ARRAY type columns from filter and sort

How to Add Metadata❓

If you wanna add metadata, look at this comment

Test Plan

  • Make a metadata with array type
  • Check if the metadata cannot be filtered or sorted
  • Check if Array type column shows data as array like [1, 2, 3, [2, 4]]

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 410da7b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66b50858865e2b0008211384
😎 Deploy Preview https://deploy-preview-9808--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review August 8, 2024 18:03
@keita-determined keita-determined requested a review from a team as a code owner August 8, 2024 18:03
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 32 lines in your changes missing coverage. Please review.

Project coverage is 50.00%. Comparing base (a11e9e8) to head (410da7b).
Report is 3 commits behind head on main.

Files Patch % Lines
webui/react/src/pages/FlatRuns/FlatRuns.tsx 3.03% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9808      +/-   ##
==========================================
- Coverage   54.27%   50.00%   -4.27%     
==========================================
  Files        1261      938     -323     
  Lines      155642   126338   -29304     
  Branches     3536     3535       -1     
==========================================
- Hits        84475    63176   -21299     
+ Misses      71029    63024    -8005     
  Partials      138      138              
Flag Coverage Δ
harness ?
web 53.69% <3.03%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/FlatRuns/FlatRuns.tsx 10.86% <3.03%> (-0.19%) ⬇️

... and 323 files with indirect coverage changes

@EmilyBonar
Copy link
Contributor

@keita-determined How do I add metadata to a run/create a run with metadata?

@keita-determined
Copy link
Contributor Author

keita-determined commented Aug 9, 2024

i ususually use this API

For example:

image
curl -X 'POST' \
  'http://latest-main.determined.ai:8080/api/v1/runs/46434/metadata' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "runId": 46434,
  "metadata": {
    "aa": 1,
    "a": "test",
    "b" : "ff"
  }
}'

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, though it displays arrays like this [1,2,3,[2,4]] with all the spaces removed, which looks a little cramped.

@keita-determined
Copy link
Contributor Author

Works, though it displays arrays like this [1,2,3,[2,4]] with all the spaces removed, which looks a little cramped.

yep JSON.stringify remove the spaces. Even if i set the space arg it wouldnt look like what we want. I also considered making a function, but i might be complicated to handle the edge cases. I'll leave it as it is for now.

@keita-determined keita-determined merged commit 9da5620 into main Aug 12, 2024
88 of 101 checks passed
@keita-determined keita-determined deleted the feature/handle-array-type-column branch August 12, 2024 18:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants