-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(Profile): #1930 update profile schema and tested #222
base: main
Are you sure you want to change the base?
Conversation
…ofile Schema, and tested
|
@@ -44,6 +44,18 @@ | |||
"config": { | |||
"provider": "azure-storage" | |||
} | |||
}, | |||
"location": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can give it a more specific name? Is location a zip code, country, time zone or something else?
"location": { | ||
"type": "string" | ||
}, | ||
"role": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the user's role (developer, designer, etc) inside Dev Launchers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @chungthuang, this will describe the role they want to do or are doing, in or out of dev launchers - a designer, developer etc..
Basically how they want to be viewed as. I've attached a screenshot of the UI where i will be integrated into
![image](https://private-user-images.githubusercontent.com/125300151/366586651-2a562c3d-f66f-414f-b350-f6a7879c1f7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDMyMjUsIm5iZiI6MTczOTI0MjkyNSwicGF0aCI6Ii8xMjUzMDAxNTEvMzY2NTg2NjUxLTJhNTYyYzNkLWY2NmYtNDE0Zi1iMzUwLWY2YTc4NzljMWY3ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwMzAyMDVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kOTlmZjM5MDJlMjlmNzU1YzRmNjMyZGMzMGVkMWNkOTZlOGJkNjMwZDllNTY0ZDk0NzdhOTNkMzNiYTM3MTM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bSV3y1Ta8XYt491wT2imyLvXlmrZelXcBPst0g8hjDg)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this looks like we have category of roles (developer, UX/UI, other) which is similar to roleCategory in opportunity collection. I think this is a good use case for components, so we share the same role category across our collections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like 64f2042.
"headline": { | ||
"type": "string" | ||
}, | ||
"website": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of website will this be? Someone's portfolio, LinkedIn, etc? Maybe this can be a list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a portfolio website. We can add a separate linkedin later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can call this field portfolioWebsite
.
@chungthuang Is this a valid story or has it already been resolved? |
const service = strapi.service("api::profile.profile"); | ||
const newProfile = await service.create({ data: config.profile }); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this newProfile associated to the current user?
How it works?
add Location, Role, Headline, Website as text under Profile Schema, and tested.