Skip to content
This repository was archived by the owner on Dec 26, 2020. It is now read-only.

make ssh client-side compression configurable #284

Merged
merged 1 commit into from
May 18, 2020
Merged

make ssh client-side compression configurable #284

merged 1 commit into from
May 18, 2020

Conversation

aqw
Copy link
Contributor

@aqw aqw commented May 14, 2020

It came as a big surprise to me that the client configuration hardcodes compression by default.

This makes it configurable, and sets it to false by default. This is a change in behavior, but I think is the correct one. It brings it in line with upstream SSH defaults, and compression has little to do with security (which is the primary goal of this role).

I chose not to rename ssh_compression to ssh_server_compression because I did not want to cause breakage for those already using it. Please feel free to adjust this PR if you would prefer the more specific naming.

@aqw
Copy link
Contributor Author

aqw commented May 14, 2020

The failure seems unrelated to this change, and is the introduction of an additional cipher (sntrup4591761x25519-sha512@tinyssh.org) on Fedora.

 ×  ssh-09: Client: Check for secure ssh Key-Exchange Algorithm
     ×  SSH Configuration KexAlgorithms is expected to eq "curve25519-sha256@libssh.org,diffie-hellman-group-exchange-sha256"

     expected: "curve25519-sha256@libssh.org,diffie-hellman-group-exchange-sha256"
          got: "sntrup4591761x25519-sha512@tinyssh.org,curve25519-sha256@libssh.org,diffie-hellman-group-exchange-sha256"

@rndmh3ro
Copy link
Member

Thanks @aqw!

You're absolutely right about all points.

Can you please sign-off your commits?

@aqw
Copy link
Contributor Author

aqw commented May 16, 2020

@rndmh3ro Done. I've been meaning to set that up for ages. Thanks for the kick. :-)

Signed-off-by: Alex Waite <alex@waite.eu>
@aqw
Copy link
Contributor Author

aqw commented May 16, 2020

I just realized you were asking for the commit to be signed-off, not necessarily signed with GPG.

In any case, both have now been done.

@rndmh3ro rndmh3ro merged commit 2c0fb49 into dev-sec:master May 18, 2020
@rndmh3ro rndmh3ro added the major label May 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants