This repository was archived by the owner on Dec 26, 2020. It is now read-only.
fix sftp_umask; store as literal not octal #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numbers with leading zeros need to be quoted in Ansible, otherwise they are interpreted as octal. Which the templating happily writes out in... decimal. In this case, sftp_umask 0027 was ending up as 23 in sshd.conf. Signed-off-by: Alex Waite <alex@waite.eu>
schurzi
approved these changes
Jul 28, 2020
|
thanks for spotting this 👍 |
|
Thanks for the merge! |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers with leading zeros need to be quoted in Ansible, otherwise they are interpreted as octal. Which the templating happily writes out in... decimal.
In this case, sftp_umask 0027 was ending up as 23 in sshd.conf.
On a Debian Buster system, fixing this did not result in a change in the default umask applied, so I assume that
internal-sftpignored '23' and fell back to 0027 as its default (as is the case on Debian). Other distros/systems with alternate defaults will likely experience a change in behavior.