OpenSSH 8.0 KEXs support #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sfuerte <16941995+sfuerte@users.noreply.github.com>
Signed-off-by: sfuerte <16941995+sfuerte@users.noreply.github.com>
chris-rock
reviewed
May 23, 2020
There was a problem hiding this comment.
Thank you very much @sfuerte for that addition. It looks great. I added a minor idea for improvement
libraries/ssh_crypto.rb
Outdated
| when /^42\./ | ||
| kex = kex66 | ||
| end | ||
| kex = inspec.os[:release] == '15.2' ? kex80 : kex66 |
There was a problem hiding this comment.
I think we should ensure that all versions 15.x > 15.2 should use kex80
There was a problem hiding this comment.
sure, updated below.
Signed-off-by: sfuerte <16941995+sfuerte@users.noreply.github.com>
atomic111
approved these changes
May 25, 2020
|
Great addition @sfuerte |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #144
added URLs for future package version quick reference & check; can be removed though.