Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(ci): add generic rust ci workflow and include controller/scheduler call #22

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

charley04310
Copy link
Contributor

@charley04310 charley04310 commented Aug 28, 2023

What is this PR for ?

This pull request introduces 3 new GitHub Actions workflows to improve the continuous integration (CI) process for all the teams working on the codebase :

  1. controller.yaml and scheduler.yaml:

They are both sharing the same template to streamline their CI processes.

  • Trigger event: These workflows are triggered on every push event that modifies any files in their respective directories.
  • Purpose: It serves as a specialized CI workflow for changes in the respective teams directories, ensuring that all updates to these components are tested.
  1. rust-ci.yaml:
  • Trigger event: This workflow can be invoked manually from any directory using a workflow call with an entry specifying the target directory.
  • Purpose: It provides a generic CI workflow for Rust codebase, allowing teams to test various components with a simple input setup. This workflow focuses specifically on ensuring code formatting and linting compliance.

Tests

You can find all passed test here

Signed-off-by: Charley <charley.geoffroy@etu.umontpellier.fr>
Signed-off-by: Charley <charley.geoffroy@etu.umontpellier.fr>
run: cargo fmt --check

- name: Run lint
run: cargo clippy -- -D warnings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do we actually build the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to understand ? Do I also need to add a build test ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. A CI should at least build the project and all its components.

@charley04310 charley04310 requested a review from sameo August 28, 2023 16:52
Signed-off-by: Charley <charley.geoffroy@etu.umontpellier.fr>
@sameo sameo merged commit f24edaa into dev-sys-do:main Aug 29, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants