Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Olimex STM32-H103 #32

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Conversation

jeanthom
Copy link
Contributor

@jeanthom jeanthom commented Apr 5, 2021

No description provided.

Copy link
Owner

@devanlai devanlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeanthom, thanks for contributing a configuration for the STM32-H103. I don't have a board to test with, but based on the schematic, it looks like there are some minor tweaks that could be made.

I'd appreciate it if you could test the bootloader with those tweaks and confirm that everything still works.

src/stm32f103/olimexstm32h103/config.h Outdated Show resolved Hide resolved
src/stm32f103/olimexstm32h103/config.h Outdated Show resolved Hide resolved
src/stm32f103/olimexstm32h103/config.h Outdated Show resolved Hide resolved
@jeanthom
Copy link
Contributor Author

jeanthom commented Apr 6, 2021

Hi, thanks for your feedback. I tried to fix everything, but for the LED I'm not sure how to test it? I haven't tried uploading firmwares yet, just made sure that I could enter the bootloader with the button or via the RTC registers and that it enumerated properly.

@devanlai
Copy link
Owner

devanlai commented Apr 6, 2021

Upon closer inspection, the bootloader doesn't actually do anything with the LED other than making sure it's off, so it doesn't make much of a difference, though maybe at some point in the future I'll make it blink the LED or something. I'm happy with these changes, so I'll go ahead and merge it now.

@devanlai devanlai merged commit 2040e7a into devanlai:master Apr 6, 2021
@jeanthom
Copy link
Contributor Author

jeanthom commented Apr 6, 2021

Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants