Skip to content

use whole dir as project base name #661

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use whole dir as project base name #661

wants to merge 1 commit into from

Conversation

NerdToMars
Copy link

To address #659

@NerdToMars NerdToMars requested a review from a team as a code owner October 21, 2023 15:19
samruddhikhandale
samruddhikhandale reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you help add tests to validate this change?

@chrmarti
Copy link
Contributor

If someone had existing containers using only the basename, wouldn't this change abandon these and create new ones with the new project name?

Csaba1205
Csaba1205 suggested changes Apr 24, 2024
View reviewed changes
Copy link

@Csaba1205 Csaba1205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale left review comments

@chrmarti chrmarti Awaiting requested review from chrmarti

+1 more reviewer

@Csaba1205 Csaba1205 Csaba1205 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NerdToMars @chrmarti @samruddhikhandale @Csaba1205