Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added build cli options proposal #328

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Added build cli options proposal #328

merged 3 commits into from
Jan 10, 2024

Conversation

Roemer
Copy link
Contributor

@Roemer Roemer commented Oct 31, 2023

Added a simple proposal for the spec change in #324

@Roemer Roemer requested a review from a team as a code owner October 31, 2023 13:53
@Roemer Roemer mentioned this pull request Oct 31, 2023
Merged
samruddhikhandale
samruddhikhandale reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time in contributing this proposal, we appreciate it 👏

@Roemer Roemer force-pushed the proposal/build-cli-options branch from 49aeb7f to ba2a264 Compare November 1, 2023 09:29
@Roemer Roemer mentioned this pull request Nov 1, 2023
Closed
chrmarti
chrmarti requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal! Left a few questions.

@Roemer Roemer force-pushed the proposal/build-cli-options branch from ba2a264 to a92b465 Compare November 1, 2023 10:20
@Roemer
Copy link
Contributor Author

Roemer commented Nov 7, 2023 •
edited
Loading

I just stumpled uppon problems with features as well. Should this proposal also add a point that those options should also be added when adding features? I am not totally sure how features work. Are they processed in separate build commands? If so, then the options should just be passed there as well.

@Roemer Roemer mentioned this pull request Nov 7, 2023
Open
@Roemer Roemer requested a review from chrmarti November 7, 2023 09:08
@chrmarti
Copy link
Contributor

chrmarti commented Dec 1, 2023

The image is built in a single docker build run, adding build args to features might allow for conflicting arguments.

chrmarti
chrmarti approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eljog
eljog approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@eljog eljog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@chrmarti @eljog
Update proposals/build-options.md
d6c2f55 
Co-authored-by: Eljo George <eljog@github.com>
@chrmarti chrmarti merged commit 299158f into devcontainers:main Jan 10, 2024
1 check passed
@chrmarti chrmarti mentioned this pull request Jan 15, 2024
Closed
chrmarti added a commit that referenced this pull request Jan 15, 2024
@chrmarti
Add build options (#328)
be7b426
@chrmarti chrmarti mentioned this pull request Jan 15, 2024
Closed
@Roemer Roemer deleted the proposal/build-cli-options branch January 15, 2024 15:08
113ll3
113ll3 reviewed Jan 26, 2024
View reviewed changes
Copy link

@113ll3 113ll3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a buzz

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale left review comments

@bamurtaugh bamurtaugh bamurtaugh left review comments

@113ll3 113ll3 113ll3 left review comments

@chrmarti chrmarti chrmarti approved these changes

@eljog eljog eljog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Roemer @chrmarti @eljog @samruddhikhandale @bamurtaugh @113ll3