Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Webhook Subscription Resolution Changes #56

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

tsutomi
Copy link
Member

@tsutomi tsutomi commented Oct 29, 2023

The IWebhookSubscriptionResolver is a service that is not necessarily bound to the Webhook Subscription Management package: future implementations might use a remote service to query them (eg. in a microserviced architecture).

The changes contained in this Pull Request

  • Remove the logical registration of the IWebhookSubscriptionResolver from the WebhookSubscriptionBuilder object
  • The DefaultWebhookSubscriptionResolver is registered by default when registering the Webhook Notifier service (can be overridden with calls to .UseSubscriptionResolver() from the builder)

@tsutomi tsutomi added the enhancement New feature or request label Oct 29, 2023
@tsutomi tsutomi self-assigned this Oct 29, 2023
@tsutomi tsutomi linked an issue Oct 29, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@tsutomi tsutomi merged commit f78366c into main Oct 29, 2023
@tsutomi tsutomi deleted the 55-design-change-to-the-webhook-subscription-builder branch October 29, 2023 22:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design Change to the Webhook Subscription Builder
1 participant