Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: preserve terser annotations regexp #875

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Fix: preserve terser annotations regexp #875

merged 3 commits into from
Oct 6, 2021

Conversation

dwightjack
Copy link
Contributor

Related to #871.

This PR fixes the regexp that preserves terser annotations in bundles.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2021

🦋 Changeset detected

Latest commit: d3ffb59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
microbundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! What a silly mistake on my part - thanks for catching this.

@developit
Copy link
Owner

Test failures all seem to be due to output for TS CJS/UMD bundles now marking require().default as /*#__PURE__*/. Seems a bit explicit, but I don't think there's a TS option that turns off insertion just for default imports.

@dwightjack
Copy link
Contributor Author

@developit I am not sure about the action required to fix the CI issue. Is it fine to update the snapshot, or should I do something else?

@developit
Copy link
Owner

@dwightjack updating the snapshot would be a good first step, yep. We can review the changes individually then.

@dwightjack
Copy link
Contributor Author

@developit Thanks! I've updated the snapshot. Changes included terser annotations and bundle size change (increased, I guess, because of the annotations).

@developit developit merged commit 5d0465b into developit:master Oct 6, 2021
@preact-bot preact-bot mentioned this pull request Oct 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants