feat: ✨ Closes #497: preserve trailing newline in mangle.json #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds editorconfig & index.js changes to enable trailing new line detection & addition in mangle.json *
🦋 Changeset detectedLatest commit: 5a86e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
developit
reviewed
Aug 23, 2021
developit
approved these changes
Oct 6, 2021
.editorconfig
Outdated
| # enabled trailing newline on | ||
| # mangle.json files | ||
| [{mangle.json,**/mangle.json}] | ||
| insert_final_newline = true |
There was a problem hiding this comment.
This should be covered by the wildcard above already?
There was a problem hiding this comment.
This also doesn't affect anyone using the project, so I've removed it
Merged
developit
added a commit
that referenced
this pull request
Jan 20, 2022
* Fix mangle.json being overwritten with [object Object] Regression from #882. * Create gorgeous-singers-invite.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
This commit adds editorconfig & index.js changes to enable trailing new line detection & addition in mangle.json