fix: Corrects completion message to show the package's name, rather than the safe name #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67deaab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Does this change the name for multi-entry? |
|
Not sure I understand. Mutli-entry shouldn't be impacted in any way to my knowledge, the only thing that changes is the name in the output message. Assuming a pkg with Before: After: Just has been a minor annoyance I've had in packages with hyphenated names. |
name, rather than the safe name
rschristian
force-pushed
the
fix/pkg-name-msg
branch
from
7a8d825 to
67deaab
Compare
ForsakenHarmony
approved these changes
Oct 7, 2021
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a minor annoyance
As far as I know there's no reason we need to display the safe name here, and (IMO) it's better if the displayed name is the package's actual name or (in the case of a missing
"name"in thepkg.json) the directory name.