chore: Silence warnings when using 'node:' protocol #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b70d7d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
May 4, 2022
| @@ -347,7 +347,7 @@ function createConfig(options, entry, format, writeMeta) { | |||
| // We want to silence rollup warnings for node builtins as we rollup-node-resolve threats them as externals anyway | |||
| // @see https://github.com/rollup/plugins/tree/master/packages/node-resolve/#resolving-built-ins-like-fs | |||
| if (options.target === 'node') { | |||
| external = external.concat(builtinModules); | |||
| external = [/node:.*/].concat(builtinModules); | |||
There was a problem hiding this comment.
I purposefully replaced external here as otherwise we get duplicates.
Line 339 in 6c59174
developit
approved these changes
May 4, 2022
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution for matching builtins doesn't catch imports using the new-ish
node:protocol:This just adds it to the patterns to match against when the target for Microbundle is Node.