-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
WIP: Add lastModified field to generated index file #248
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
I added the gosec exemption as it is following and cleaning the path the same as the following: |
https://github.com/devfile/registry-support/actions/runs/9617745553/job/26530169277?pr=248 should be resolved after devfile/registry#429 is merged |
Going to close - I'll open a new PR with the index/server changes. It will be too much of a headache to have them in separate PRs for tests |
Please specify the area for this PR
What does does this PR do / why we need it:
This is the first PR aimed at supporting a
lastModified
query parameter for filtering data. The changes made as part of this PR add functionality for reading alast_modified.json
file that is added to theregistry
directory during build. The goal is to read these values and assign them to their proper stack/sample versions they belong to within the generatedindex
file.In addition to this functionality I had to do more data manipulation to allow for the proper setting of these values, it is easier to do this in
go
rather thanbash
so it was done here instead of devfile/registry#429.Additionally, tests were updated to contain the new field so we can ensure it is being added correctly.
FYI changes still need to be made on the
index/server
side for the actual endpoint, this is just theindex/generator
work for the index file.Which issue(s) this PR fixes:
fixes devfile/api#1327
PR acceptance criteria:
Documentation (WIP)
How to test changes / Special notes to the reviewer:
Go tests should pass - The new field was added to the expected index file.