Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update index/generator version for registry-library #253

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Jdubrick
Copy link
Contributor

Please specify the area for this PR

What does does this PR do / why we need it:
This PR accomplishes the following:

  • index/generator reference updated to cf509cc as it pulls in security fix
  • go mod vendor ran

Which issue(s) this PR fixes:
Part of devfile/api#1620

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick Jdubrick requested review from thepetk, michael-valdron and a team August 16, 2024 15:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm after all checks are passing.

I'm curious, I see it also updates the indirect dependencies of k8s.io to v0.29.2 (comes after the general bump we did for all modules). I don't expect any breaking changes as they would have been seen in the direct dependencies already. Just thinking in the future we might want to include this in a list of items when we do similar bumps across all modules/projects

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
Copy link

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

/lgtm after all checks are passing.

I'm curious, I see it also updates the indirect dependencies of k8s.io to v0.29.2 (comes after the general bump we did for all modules). I don't expect any breaking changes as they would have been seen in the direct dependencies already. Just thinking in the future we might want to include this in a list of items when we do similar bumps across all modules/projects

Yeah I initially saw that too, I think it should be okay since the most breaking change of that bump was the Go version I believe? And this already uses 1.21.

+1 on taking note for when we bump other projects though.

@Jdubrick Jdubrick merged commit 30dce46 into devfile:main Aug 16, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants