Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

basic login with G-# #3

Merged
merged 15 commits into from
May 29, 2019
Merged

basic login with G-# #3

merged 15 commits into from
May 29, 2019

Conversation

killbotXD
Copy link
Contributor

@killbotXD killbotXD commented May 28, 2019

Screenshot from 2019-05-28 14-02-47

@killbotXD killbotXD closed this May 28, 2019
Copy link
Member

@ajatprabha ajatprabha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes are good, left a few comments, please resolve them. And I would like to see some tests built around this Login Component.

@ajatprabha ajatprabha reopened this May 28, 2019
@killbotXD killbotXD closed this May 28, 2019
@killbotXD killbotXD reopened this May 28, 2019
@ajatprabha
Copy link
Member

LGTM, thanks for the changes! 🎉

@ajatprabha ajatprabha merged commit c534d55 into devlup-labs:master May 29, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants