Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Kaniko doesn't work under loft #1126

Closed
abh opened this issue Jul 3, 2020 · 3 comments
Closed

Kaniko doesn't work under loft #1126

abh opened this issue Jul 3, 2020 · 3 comments
Assignees
Labels
area/building-images Issues related to building Docker images kind/feature New feature or feature request

Comments

@abh
Copy link

abh commented Jul 3, 2020

When using loft there's a no default resource limits configured, so kaniko fails with an error that resource limits aren't specified. If devspace set (or had options to configure) limits on kaniko this would work.

@FabianKramm
Copy link
Collaborator

FabianKramm commented Jul 3, 2020

@abh thanks for opening this issue! In general, the recommended approach here is to create a limit range resource (https://kubernetes.io/docs/concepts/policy/limit-range/) in the namespace (can be done automatically in loft via space templates on space create) that will automatically set the resource limits based on your configuration if they are not specified.

Besides from that approach, we can also add an option to devspace to specify resource limits, since it might be helpful to restrict the kaniko pod in certain circumstances, so I'll flag this as a new feature.

@FabianKramm FabianKramm self-assigned this Jul 3, 2020
@FabianKramm FabianKramm added area/building-images Issues related to building Docker images kind/feature New feature or feature request labels Jul 3, 2020
@abh
Copy link
Author

abh commented Jul 3, 2020

@FabianKramm Thanks! I couldn't get the template feature in loft to work so I added the LimitRange manually with an admin account on the cluster.

I opened this issue for the use case you mentioned of needing different resources than the default.

@FabianKramm
Copy link
Collaborator

@abh implemented in v4.14.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/building-images Issues related to building Docker images kind/feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants