Skip to content

Commit

Permalink
fix path problem
Browse files Browse the repository at this point in the history
  • Loading branch information
PaleNeutron committed Aug 18, 2023
1 parent 46ea4c7 commit d0fe738
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion dataframe_image/_browser_pdf.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ def get_pdf_data(file_name, p):

def get_pdf_data_chromecontroller(file_name):
additional_options = get_launch_args()
# ChromeContext will shlex.split binary, so add quote to it
with ChromeController.ChromeContext(
binary=get_chrome_path(), additional_options=additional_options
binary=f'"{get_chrome_path()}"', additional_options=additional_options
) as cr:
# Do a blocking navigate to a URL, and get the page content as served by the remote
# server, with no modification by local javascript (if applicable)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def tname_to_filename(test_name:str):
@pytest.mark.parametrize("execute", executes, ids=["executed", ""])
@pytest.mark.parametrize("no_input", no_input, ids=["no_input", ""])
class TestConvertPDF:
def test_same_folder(self, request, filename, use, execute, no_input):
def test_to_pdf(self, request, filename, use, execute, no_input):
document_name = tname_to_filename(request.node.name)
convert(
filename, to="pdf", use=use, execute=execute, document_name=document_name, no_input=no_input
Expand All @@ -37,7 +37,7 @@ def test_same_folder(self, request, filename, use, execute, no_input):
@pytest.mark.parametrize("execute", executes, ids=["executed", ""])
@pytest.mark.parametrize("no_input", no_input, ids=["no_input", ""])
class TestConvertMD:
def test_same_folder(self, request, filename, execute, no_input):
def test_to_md(self, request, filename, execute, no_input):
document_name = tname_to_filename(request.node.name)
convert(filename, to="md", execute=execute, document_name=document_name, no_input=no_input)

Expand Down

0 comments on commit d0fe738

Please # to comment.