fix(https-outcalls): Increase allowed header size limit for HTTP/2 requests #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumenov
approved these changes
Oct 28, 2024
DSharifi
commented
Oct 28, 2024
DSharifi
changed the title
marko-k0
approved these changes
Oct 28, 2024
DSharifi
changed the title
DSharifi
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling h/2 with outcalls we had a regression where responses to https outcalls with headers greated than 16KB would fail. In hyperium/hyper-util#154 (comment) hyper-util exposes a method to increase the header response limit.
This PR increases the limit to 52KiB, above 48KiB in the spec, to not block this weeks release in case the spec-compliance tests have any headers hardcoded that can break the test. We can reduce this limit closer to 48KiB in the future.