fix: EXC: Fix embedder heap benchmarks #4457
Open
+105
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates embedder heap benchmarks baseline results and adds minor changes to the benchmark scripts. Overall the heap benchmarks regressed 11.8% compared to the latest master.
adambratschikaye
approved these changes
Mar 24, 2025
Comment on lines
+121
to
+125
| match post_setup_action { | ||
| PostSetupAction::PerformCheckpoint => { | ||
| test.checkpoint_canister_memories(); | ||
| } | ||
| PostSetupAction::None => {} |
There was a problem hiding this comment.
Maybe we should change the name from PostSetupAction now that it's run every iteration?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates embedder heap benchmarks baseline results and adds minor changes to the benchmark scripts.
Overall the heap benchmarks regressed 11.8% compared to the latest master.