Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update showcase.json from Faceless project #1513

Merged
merged 5 commits into from
Oct 28, 2023

Conversation

HeisenbergLin22
Copy link
Contributor

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

@HeisenbergLin22 HeisenbergLin22 requested a review from a team as a code owner May 30, 2023 05:19
@ghost
Copy link

ghost commented May 30, 2023

Dear @HeisenbergLin22,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@ghost ghost added the cla:pending label May 30, 2023
@ghost
Copy link

ghost commented May 30, 2023

Dear @HeisenbergLin22,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@domwoe
Copy link
Contributor

domwoe commented Aug 28, 2023

@HeisenbergLin22 Could you please accept the CLA?

@jennifertrin
Copy link
Contributor

Hello @HeisenbergLin22, can you please complete the CLA steps listed in this PR?

@ghost ghost added cla:agreed and removed cla:pending labels Oct 7, 2023
@HeisenbergLin22
Copy link
Contributor Author

issue

Hey, I haven't checked my GitHub message for a while, sorry for the late response. I've approved the CLA, and here is the link: dfinity/cla#246 (comment)

@sa-github-api
Copy link

Dear @HeisenbergLin22,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@HeisenbergLin22
Copy link
Contributor Author

Dear @HeisenbergLin22,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

Hey, as you can see from this link: dfinity/cla#247 (comment) and this link: dfinity/cla#247 (comment), I copied the sentence exactly to approve the CLA, but somehow the github-actions bot keeps saying "Your comment does not match the CLA agreement.". Would you please check which part of my comment is invalid? Thanks.

@jennifertrin
Copy link
Contributor

Dear @HeisenbergLin22,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation

Hey, as you can see from this link: dfinity/cla#247 (comment) and this link: dfinity/cla#247 (comment), I copied the sentence exactly to approve the CLA, but somehow the github-actions bot keeps saying "Your comment does not match the CLA agreement.". Would you please check which part of my comment is invalid? Thanks.

Hello @HeisenbergLin22, can you please only write a comment without replying?

See this as an example: dfinity/cla#375

@HeisenbergLin22
Copy link
Contributor Author

Dear @HeisenbergLin22,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation

Hey, as you can see from this link: dfinity/cla#247 (comment) and this link: dfinity/cla#247 (comment), I copied the sentence exactly to approve the CLA, but somehow the github-actions bot keeps saying "Your comment does not match the CLA agreement.". Would you please check which part of my comment is invalid? Thanks.

Hello @HeisenbergLin22, can you please only write a comment without replying?

See this as an example: dfinity/cla#375

Hey @jennifertrin , thanks for your suggestion. It works

@domwoe domwoe enabled auto-merge (squash) October 20, 2023 06:52
@jennifertrin
Copy link
Contributor

Hello @HeisenbergLin22 Can you please add a tag value for Faceless?

@domwoe domwoe merged commit 972e902 into dfinity:master Oct 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants