-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: Improve Error Handling by Adding Display Implementations #140
Conversation
Dear @b3hr4d, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
Dear @b3hr4d, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
Dear @b3hr4d, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@b3hr4d I think you need to sign the CLA for us to be able to merge this commit. |
I, b3hr4d, hereby agree to the DFINITY Foundation's CLA. |
This pull request aims to improve the error-handling mechanism of the codebase by providing more descriptive error messages. It involves changes across multiple files (
cell.rs
,log.rs
) to add implementations for thefmt::Display
trait forInitError
.Key Changes:
Consistent Formatting: Replaced
std::fmt
withfmt
to maintain consistency in the code.btreemap.rs
Enhanced Error Messages for
InitError
incell.rs
:Detailed Error Messages for
InitError
inlog.rs
:Why this is important:
Better error messages enhance the debugging experience and allow developers to understand the issues quickly, thereby saving time and effort.
Files Changed:
src/btreemap.rs
src/cell.rs
src/log.rs
Types of changes: