Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: implement storable for bool #186

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat: implement storable for bool #186

merged 7 commits into from
Jan 31, 2024

Conversation

linnefromice
Copy link
Contributor

solution for #185

@linnefromice linnefromice requested a review from a team as a code owner January 30, 2024 01:36
@sa-github-api
Copy link

Dear @linnefromice,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

linnefromice
linnefromice commented Jan 30, 2024
View reviewed changes
src/storable.rs Outdated Show resolved Hide resolved
@linnefromice
Copy link
Contributor Author

@ielashi Could you please check this?

ielashi
ielashi reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@ielashi ielashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Some minor comments.

src/storable.rs Outdated Show resolved Hide resolved
src/storable.rs Outdated Show resolved Hide resolved
src/storable.rs Outdated Show resolved Hide resolved
@linnefromice
Copy link
Contributor Author

@ielashi Thanks for your review.
All your suggestions were smart. I have accepted your suggestions and revised the test. I want you to look again.

@ielashi ielashi changed the title implement storable in bool of scalar type feat: implement storable for bool Jan 31, 2024
@ielashi
Copy link
Contributor

ielashi commented Jan 31, 2024

LGTM! Looks like clippy is complaining though.

@linnefromice linnefromice requested a review from ielashi January 31, 2024 12:16
@linnefromice
Copy link
Contributor Author

Looks like clippy is complaining though.

Sorry, I didn't check the results of the CI run.
corrected by f11d61e

@ielashi ielashi merged commit 45d75c4 into dfinity:main Jan 31, 2024
7 checks passed
@linnefromice linnefromice deleted the topic/storable-bool branch January 31, 2024 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ielashi ielashi ielashi approved these changes

Assignees
No one assigned
Labels
external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linnefromice @sa-github-api @ielashi