Add support for sampler settings to more types of textures. #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, texture(3d), rt, image(3d), and cube maps. This includes min/mag settings and wrap settings as appropriate. Access the settings with the new "Sampler" subtree in the properties list. Tested round trip load/save operation with Image3D and live updating of sampler settings. Desk checked for other types of objects.
|
Checked the code and looks fine to me |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, texture(3d), rt, image(3d), and cube maps. This includes min/mag settings and wrap settings as appropriate. Access the settings with the new "Sampler" subtree in the properties list.
Tested round trip load/save operation with Image3D and live updating of sampler settings. Desk checked for other types of objects.
This pipeline uses a compute shader to fill an Image3D with a gradient rgb = xyz. This pixel shader is sampling that texture along u, v, 0.5.
And with different sampling
