Fix numeric column formatting #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
6 times, most recently
from
4271a41 to
7c9ff39
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some numeric columns in database for which Dibi fails with TypeError
explode() expects parameter 2 to be string, int given.I have fixed the case
athat failed in our code, but it seems the same issue might be in casesvandmas well. I don't quite understand Dibi internals so I am unable to verify if it's a real problem in these cases.The issue happens with code like
$connection->update('table', [10 => 'foo'])>where('id = %i', 1)->execute();If you could also backport the fix to the v4.2 branch, it would be welcome.
Thank you