Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Work with context.Context & deprecates io/ioutil #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Work with context.Context & deprecates io/ioutil #79

wants to merge 2 commits into from

Conversation

gawen
Copy link

@gawen gawen commented Oct 25, 2024 •
edited
Loading

What changed?

⚠️ This PR will break retro-compatibility. I don't know if it is acceptable and will leave it to the appreciation of the reviewer.

  1. Config.RequestToken() and Config.AccessToken() now requires a context.Context
  2. Deprecates io/ioutil and replaces by io

@gawen gawen mentioned this pull request Oct 25, 2024
Closed
@dghubble
Copy link
Owner

Swapping out io/ioutil yes, changing the signatures probably no.

@gawen
Copy link
Author

gawen commented Oct 28, 2024

💭 Let's provide RequestTokenWithContext and AccessTokenWithContext?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gawen @dghubble