Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature request: Occurrences, real type, and last child indicator are shown in TXT/CSV export; exporting stops when reached the final expanding level on all branches #22

Closed
TCH68k opened this issue Oct 16, 2019 · 6 comments

Comments

@TCH68k
Copy link

TCH68k commented Oct 16, 2019

So, i put everything into XSD Diagram's exporter, what i needed and made a new patch: http://oscomp.hu/depot/xsddiagram.diff

@TCH68k TCH68k changed the title Feature request: Ocurrences, real type, and last child indicator are shown in TXT/CSV export; exporting stops when reached the final expanding level on all branches Feature request: Occurrences, real type, and last child indicator are shown in TXT/CSV export; exporting stops when reached the final expanding level on all branches Oct 16, 2019
@paulushub
Copy link
Collaborator

Exclude binary files from your patch.

@TCH68k
Copy link
Author

TCH68k commented Oct 16, 2019

Sorry, Kompare did not listed them and i did not notice. Patchfile has been updated.

@dgis
Copy link
Owner

dgis commented Oct 17, 2019

Thank you for your contribution.
I succeeded to apply your patch and tested it. All seems to work.
I wonder what the purpose of LASTCHILD, but why not.
I can add it to the main branch and I could make a new version soon.

@paulushub
Copy link
Collaborator

@dgis Before commit, change the name of the DiagramTxtRenderer also, it is still SVG

public override string Name
{
    get
    {
        return "SVG";
    }
}

@TCH68k
Copy link
Author

TCH68k commented Oct 17, 2019

@dgis
Thank you for merging.

The purpose of LASTCHILD is that it marks the line as a last child on a branch.
My current task is to create a specific HTML tree out of XSD files and i solved it by processing the TXT output of XSD Diagram, but since i'm processing the resulting TXT files sequentially (the XSD-s can be enormous, so i did not wanted to double the processing time by collecting everything in the file and rebuild the tree and i could not just integrate that specific HTML output into XSD Diagram, as it would be useless for the users) and i need to show the "lines" which symbolizing the paths, i have to know if a parent will have more siblings after it's children.
I know it's very specific, but it's optional and it can be useful.

@dgis
Copy link
Owner

dgis commented Oct 21, 2019

@paulushub I change that. Thank you.
@TCH68k OK, I understand. Thank you very much for your patch.
I will push your patch today but I will make a new official release 1.3 later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants