fix(stream): improve incremental stream writer #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
akon-dey,
billprovince,
joshua-goldstein and
skrdgraph
as code owners
mangalaman93
force-pushed
the
aman/bug
branch
3 times, most recently
from
fef30d6
to
f330119
Compare
mangalaman93
changed the title
joshua-goldstein
previously approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Looks good! Let's get #1908 in first so Dgraph tests run against this (don't think there is an issue but it will be good to see the workflow run).
mangalaman93
requested review from
harshil-goel
and removed request for
skrdgraph
This commit fails incremental stream writer if memtable has data. It also allows calling incremental stream writer more times than the number of levels we have. This is done by calling Flatten when we have want to write and L0 already has data.
harshil-goel
approved these changes
Jun 12, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fails incremental stream writer if memtable has data. It also allows calling incremental stream store more times than the number of levels we have. This is done by calling Flatten when we have reached L0 and incremental stream writer can be used again.