Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

change expiration type from int64 to time.Time #277

Merged
merged 1 commit into from
May 21, 2021
Merged

change expiration type from int64 to time.Time #277

merged 1 commit into from
May 21, 2021

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented May 20, 2021 •
edited by manishrjain
Loading

FIX: https://discuss.dgraph.io/t/setwithttl-doesnt-work/14192

I did git bisect with added test and found #195 makes this broken.

#195 has 2 changes.

  1. change expiration type from time.Time to int64
  2. add a flag to toggle cost calculation

I reverted 1, and the test is fixed.

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented May 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@karlmcguire
Copy link
Contributor

Great catch, thanks @Warashi!

@karlmcguire karlmcguire merged commit 9d4946d into dgraph-io:master May 21, 2021
@jarifibrahim jarifibrahim mentioned this pull request May 24, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Warashi @CLAassistant @karlmcguire