Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Styling input type=tel elements #67

Closed
wants to merge 2 commits into from
Closed

Styling input type=tel elements #67

wants to merge 2 commits into from

Conversation

mileszs
Copy link

@mileszs mileszs commented Feb 2, 2012

Hello, sir!

Thank you for Skeleton. I've really enjoyed using it these past few weeks. Today I noticed that input elements of the type "tel" are not styled the same as text, email, and password input elements. It is likely that the tel type is used much more infrequently, but either Ruby on Rails 3.2, or the form builder library I am using in this project, generated an input[type="tel"] for a field called "phone", which makes good sense ultimately. I thought I'd add in the two lines it would take to get them styled similarly.

Thanks again!

@matthewkimber
Copy link

I second this HTML5 input styling. However, it would be great to include all input types defined by the W3C (i.e. number, tel, email, url, datetime, date, week, time, etc. - http://www.w3.org/TR/html5/the-input-element.html).

@mileszs
Copy link
Author

mileszs commented Mar 7, 2012

As far as I can tell, only a subset of those listed are actually text fields, which is the target of this commit. In particular: tel, url, email, password, number, and (maybe) search. The others are different types of controls, and thus shouldn't be styled the same. Would you agree?

In any case, I'll add to the style to address the others. Hopefully we can get this pulled in to the main branch!

@gilluminate
Copy link

+1 from me. I noticed the same thing in an attept to add a type="tel" field to my project today.

@dhg
Copy link
Owner

dhg commented Dec 15, 2014

This is all great feedback and is going to get incorporated in the next Skeleton point release. I'm closing this issue (even though it's the original) since the code is out of date based on v2.0 release.

Look here for current discussion (though I'm definitely adding for next point release): #205

Thanks all!

@dhg dhg closed this Dec 15, 2014
@dhg dhg mentioned this pull request Dec 15, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants