feat: Handle Indicators and Expressions [DHIS-18321] #19708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
netroms
approved these changes
Jan 17, 2025
vietnguyen
approved these changes
Jan 17, 2025
luciano-fiandesio
pushed a commit
that referenced
this pull request
Jan 20, 2025
* feat: Handle Indicator numerator denominator refs [DHIS2-18321] * feat: Handle Expressions wth source COC refs [DHIS2-18321] * add javadoc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The requirements for the category option combo merge keep coming in :)
These 2 new scenarios are places in the DB where COC refs can be held within plain string values, which explains why they were originally missed (domain knowledge).
This PR includes handling the refs for these types and their properties:
Indicatornumerator(plain string)denominator(plain string)Expressionexpression(plain string)The merge executes an sql update using the postgres function
replacewhich replaces all occurrences of a string with another string.Testing
Automated
E2E tests added for each scenario.