-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates boxable official #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long, traveling this week.
This all looks very good and usefull, I especially like the html table rendering inside a cell.
I made a few very minor changes and think this can now be merged.
Let me know if you want to merge or if you want me to do that.
Once merged, I'll release this on Maven as 1.5
Thanks a lot!
Yeah, you can merge it 👍 I can edit README maybe tomorrow with 1.5 changes and expand our wiki a little bit. |
That would be awesome.
…On 01 Feb 2018 8:32 AM, "Hrvoje Štimac" ***@***.***> wrote:
Yeah, you can merge it 👍 I can edit README maybe tomorrow with 1.5
changes and expand our wiki a little bit.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#142 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABmqVNOXQZMLII8hEeXLzMPV6cLDiFPqks5tQecDgaJpZM4RpOXh>
.
|
Hi @Frulenzo , did you have a chance to update the readme yet? |
I already have a small text for readme, I only need to make wiki entry about new changes and how to use them. Today evening I can make readme update and over the weekend I will make a wiki entry 👍 |
I released this to the central maven repository. I think I did everything correctly, but don't see it yet here, this may just take a while to update. |
Looks like the detail page exists, just the list of versions page is not yet updated. https://search.maven.org/#artifactdetails%7Ccom.github.dhorions%7Cboxable%7C1.5%7Cjar |
@dhorions Here are my cherry-picks with some bugfixes and new features. I'm a little bit in hurry so I will edit my post here when I come home.