Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix function order [drlg_l1.cpp] #1803

Merged
merged 1 commit into from Oct 13, 2019
Merged

Fix function order [drlg_l1.cpp] #1803

merged 1 commit into from Oct 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Oct 13, 2019

Function order matches the mac, psx, and demo release. This one was easier since we have the psx symbol telling us exactly which ones are static.

PSX/MAC/DEMO             RETAIL
STAT DRLG_PlaceDoor    - DRLG_Init_Globals
STAT DRLG_L1Shadows    - LoadL1Dungeon
STAT DRLG_PlaceMiniSet - DRLG_L1Floor
STAT DRLG_L1Floor      - DRLG_L1Pass3
STAT DRLG_L1Pass3      - DRLG_InitL1Vals
STAT DRLG_LoadL1SP     - LoadPreL1Dungeon
STAT DRLG_FreeL1SP     - CreateL5Dungeon
EXT DRLG_Init_Globals  - DRLG_LoadL1SP
STAT DRLG_InitL1Vals   - DRLG_FreeL1SP
EXT LoadL1Dungeon      - DRLG_L5
EXT LoadPreL1Dungeon   - DRLG_PlaceDoor
STAT InitL5Dungeon     - DRLG_L1Shadows
STAT L5ClearFlags      - DRLG_PlaceMiniSet
STAT L5drawRoom        - InitL5Dungeon
STAT L5checkRoom       - L5ClearFlags
STAT L5roomGen         - L5firstRoom
STAT L5firstRoom       - L5drawRoom
STAT L5GetArea         - L5roomGen
STAT L5makeDungeon     - L5checkRoom
STAT L5makeDmt         - L5GetArea
STAT L5HWallOk         - L5makeDungeon
STAT L5VWallOk         - L5makeDmt
STAT L5HorizWall       - L5AddWall
STAT L5VertWall        - L5HWallOk
STAT L5AddWall         - L5VWallOk
STAT DRLG_L5GChamber   - L5HorizWall
STAT DRLG_L5GHall      - L5VertWall
STAT L5tileFix         - L5tileFix
STAT DRLG_L5Subs       - DRLG_L5Subs
STAT DRLG_L5SetRoom    - L5FillChambers
STAT L5FillChambers    - DRLG_L5GChamber
STAT DRLG_L5FTVR       - DRLG_L5GHall
STAT DRLG_L5FloodTVal  - DRLG_L5SetRoom
STAT DRLG_L5TransFix   - DRLG_L5FloodTVal
STAT DRLG_L5DirtFix    - DRLG_L5FTVR
STAT DRLG_L5CornerFix  - DRLG_L5TransFix
STAT DRLG_L5           - DRLG_L5DirtFix
EXT CreateL5Dungeon    - DRLG_L5CornerFix

@ghost ghost added the code cleanup Cosmetic enhancement to the code to make it look nicer. label Oct 13, 2019
@ghost ghost mentioned this pull request Oct 13, 2019
Closed
67 tasks
@mewmew mewmew merged commit 9aabe31 into diasurgical:master Oct 13, 2019
mewmew
mewmew reviewed Oct 13, 2019
View reviewed changes
Source/drlg_l1.h
void LoadPreL1Dungeon(char *sFileName, int vx, int vy);
void CreateL5Dungeon(DWORD rseed, int entry);
void DRLG_LoadL1SP();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great so get rid of all these functions that are only called internally.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code cleanup Cosmetic enhancement to the code to make it look nicer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mewmew @galaxyhaxz