Fix function order [palette.cpp]

[ghost]

PSX                    MAC                        1.09                       EXTERN
EXT LoadPalette        palette_update             SaveGamma                  Y   
EXT LoadRndLvlPal      ApplyGamma                 palette_init               Y   
EXT ResetPal           SaveGamma                  LoadGamma                      
STAT SetFadeLevel      LoadGamma                  LoadSysPal                     
EXT GetFadeState       [LoadSysPal]               LoadPalette                Y   
EXT DrawFadedScreen    palette_init               LoadRndLvlPal              Y   
EXT BlackPalette       LoadPalette                ResetPal                   Y   
EXT PaletteFadeInTask  LoadRndLvlPal              IncreaseGamma              Y   
EXT PaletteFadeIn      ResetPal                   palette_update                 
EXT PaletteFadeOutTask IncreaseGamma              ApplyGamma                     
EXT PaletteFadeOut     DecreaseGamma              DecreaseGamma              Y   
                       UpdateGamma                UpdateGamma                Y
                       SetFadeLevel               BlackPalette               Y
                       BlackPalette               SetFadeLevel               
                       PaletteFadeIn              PaletteFadeIn              Y
                       PaletteFadeOut             PaletteFadeOut             Y
                       palette_update_caves       palette_update_caves       Y
                       Lava2Water                 Lava2Water                 Y
                       palette_get_colour_cycling palette_get_colour_cycling Y
                       palette_set_color_cycling  palette_set_color_cycling  Y

[AJenbo]

LGTM

[AJenbo]

@galaxyhaxz p.s. any chance you could take a look at what parts of the code are changing with thease reorderings?
1% change, 2520 insertions(+), 2546 deletions(-)
1% change, 2534 insertions(+), 2562 deletions(-)

[ghost]

Just checked every function in palette.cpp in the comparer and they are still bin exact. It is probably more alignment as is with all these commits :P

[AJenbo]

Yeah I'm just wondering what specific alighment we are dealing with :)

[ghost]

I am also curious too, but it's so hard to say for sure and I don't feel like checking every function. As it was pointed out before, the docker uses a retail build with debug database enabled, which outputs a slightly different release build than one without. In my previous cases, the one without remained byte identical all the way through.

[AJenbo]

Well a full diff should be good enough :)

[AJenbo]

Took a look in to this, we do see some jitter in all the jumps and globals, but also in SpawnPremium
lea edx, [eax+ecx*1] became lea edx, [ecx+eax*1], SpawnWitch:

I guess both can be explained by the fact that they live right where the alignment issue is so removing things from the header files will cause them to jitter.