Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix function order [capture.cpp] #1870

Merged
merged 1 commit into from Dec 2, 2019
Merged

Fix function order [capture.cpp] #1870

merged 1 commit into from Dec 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2019

This file doesn't exist in the PSX or MAC, but we do have two assertions showing that CaptureScreen came after CapturePix, and given the new order the right number of lines fits between them.

Fixed           1.09             Assertion lines
CaptureHdr      CaptureScreen    250
CapturePal      CaptureHdr       
CaptureEnc      CapturePal       
CapturePix      CapturePix       169-179
CaptureFile     CaptureEnc       
RedPalette      CaptureFile      
CaptureScreen   RedPalette

@ghost ghost added Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer. labels Dec 2, 2019
mewmew
mewmew approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@mewmew mewmew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

takes screenshot

@ghost ghost mentioned this pull request Dec 2, 2019
Closed
67 tasks
@ghost
Copy link
Author

ghost commented Dec 2, 2019

We shall eternalize everything with ones and zeroes. ONES and ZEROES Morty! There just ones and zeroes! - Rick

@AJenbo
Copy link
Member

AJenbo commented Dec 2, 2019

All we ever where; just zeros and ones

@AJenbo AJenbo merged commit a0b0591 into diasurgical:master Dec 2, 2019
@mewmew
Copy link
Contributor

mewmew commented Dec 2, 2019 •
edited
Loading

10100111001

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Binary exact code cleanup Cosmetic enhancement to the code to make it look nicer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AJenbo @mewmew @galaxyhaxz