pfile cleaning #2 #373
Merged
pfile cleaning #2 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean pfile_open_save_archive clean pfile_archive_contains_game clean pfile_get_player_class clean pfile_get_file_name clean GetTempSaveNames clean GetPermSaveNames clean pfile_update clean pfile_init_save_directory clean pfile_write_hero clean pfile_open_archive clean pfile_flush_W
mewmew
approved these changes
Oct 1, 2018
Source/pfile.cpp
Outdated
| return TRUE; | ||
|
|
||
| if ( a1 && gbMaxPlayers > 1 ) | ||
| MI_Dummy(save_num); // some eliminated function... |
There was a problem hiding this comment.
This is mpqapi_update_multi_creation_time from the debug release.
There was a problem hiding this comment.
Add it in and let it get eliminated.
There was a problem hiding this comment.
Sounds good. Do you wanna update the PR with it? For reference, it's at address 0x41741F of the debug release, if you wanna check something.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't worry, these are all small (and bin exact) :
clean GetSaveDirectory and pfile_read_hero
clean pfile_open_save_archive
clean pfile_archive_contains_game
clean pfile_get_player_class
clean pfile_get_file_name
clean GetTempSaveNames
clean GetPermSaveNames
clean pfile_update
clean pfile_init_save_directory
clean pfile_write_hero
clean pfile_open_archive
clean pfile_flush_W